TAN-5756 Emails flagging and new comment bugs #12407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
jamesspeake
reviewed
Nov 4, 2025
|
|
||
| expect(command).to match( | ||
| event_payload: a_hash_including( | ||
| flaggable_author_name: 'Biggus Dickus', |
jamesspeake
approved these changes
Nov 4, 2025
Contributor
jamesspeake
left a comment
jamesspeake
left a comment
There was a problem hiding this comment.
Looks good. just think the test descriptions need changing - for me they are describing the inverse of what they are doing
Comment on lines
47
to
49
| it 'filters out moderators' do | ||
| expect(campaign.filter_recipient(User.all, activity:).ids).to match_array([admin.id, moderator.id]) | ||
| end |
Contributor
There was a problem hiding this comment.
Struggling with the language here. Do you mean it includes all admins and moderators? It's not filtering out anything?
| context 'when the author is a moderator' do | ||
| let(:author) { create(:project_moderator, projects: [idea.project]) } | ||
|
|
||
| it 'filters out no one if the author is a moderator' do |
Contributor
There was a problem hiding this comment.
Likewise here - it includes no one
| context 'when there is no author' do | ||
| let(:author) { nil } | ||
|
|
||
| it 'filters out moderators' do |
Contributor
Author
True, I saw it as things being filtered out, but actually these are more like the things the pass through the filter. I changed the wording, I hope this is less confusing, but I think it's hard to describe the filters in general. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Fixed